take period into account when collapsing stacks #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this is just the patch I need, to weight the samples by time taken rather than uniformly by |
mdcallag
added a commit
to mdcallag/FlameGraph
that referenced
this pull request
Mar 31, 2022
Summary: Disclaimer - I am not an expert on Perl, perf or FlameGraph. This is a hack for brendangregg#165 By hack I mean that it works for me but I didn't update all of the test files. The problem is that stackcollapse assumes that all stack traces have an equal weight but they don't based on based on current perf output. For example, there can be lines like this where 90689, 32298287 and 1 are the weights but stackcollapse assumes they all have weight 1, and by weight I mean the equivalent of the number of times this stack trace happens. Thus, the relative frequency of xpl_accept-3 is 1 / (90689 + 32289287 + 1). xpl_accept-1 2777710 12891973.429160: 90689 cycles: xpl_accept-2 2777710 12891975.431112: 32289287 cycles: xpl_accept-3 2777710 12891975.431112: 1 cycles: This is based on brendangregg#250 but I am not sure that PR is correct, it is also ~20 diffs behind current FlameGraph. Test Plan: works for me Reviewers: Subscribers: Tasks: Tags:
|
Thanks, merging. If this goes badly for people then please see the discussion in #165 to understand how we got here and how maybe to fix it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165