Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 1PES domain block functionality on 20% nightly. #224

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

goodov
Copy link
Member

@goodov goodov commented Feb 15, 2022

Enable 1PES mode availability in browser and enable automatic temporary 1PES when visiting blocked websites in Standard blocking mode.

This study consist of two features:

  1. BraveFirstPartyEphemeralStorage - changes one of possible cookie settings from Always clear cookies when windows are closed to Sites that clear cookies when you close them. Which allows user to basically always enable ephemeral mode for a website if it's added to the list.
  2. BraveDomainBlock1PES - enables automatic temporary 1PES for a website if it's in a blocked domains list.

brave/brave-browser#19099
brave/brave-browser#20702

@goodov goodov requested a review from a team as a code owner February 15, 2022 14:24
@kjozwiak
Copy link
Member

QA was completed on main via #223 (comment). QA also verified the feature using the STR/Cases that @goodov provided via brave/brave-browser#19099 (comment) & brave/brave-core#12089 (comment).

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the study/feature as per #223 (comment).

@kjozwiak kjozwiak merged commit 1c45189 into production Feb 24, 2022
@kjozwiak kjozwiak deleted the 1pes-nightly branch February 24, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants