Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 1PES domain block functionality on 20% nightly. #223

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Feb 15, 2022

No description provided.

@goodov goodov requested a review from a team as a code owner February 15, 2022 14:21
@goodov goodov merged commit 7c67283 into main Feb 15, 2022
@goodov goodov deleted the 1pes-nightly branch February 15, 2022 14:21
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.38.1 Chromium: 99.0.4844.45 (Official Build) nightly (64-bit)
-- | --
Revision | edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS | Windows 11 Version 21H2 (Build 22000.527)

I went through one case just to make sure that the basics are working when a user is opted into this study via FirstPartyEphemeralDomainBlockStudy:Enabled. QA went through both brave/brave-browser#19099 (comment) & brave/brave-core#12089 (comment) as well.

Example (Default) Example (Enabled)
image image

Test Case

Example Example Example Example
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants