Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6179: Add clean copy feature #7696

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Fix #6179: Add clean copy feature #7696

merged 6 commits into from
Sep 15, 2023

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Jul 7, 2023 •
edited
Loading

Summary of Changes

This pull request fixes #6179

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Navigation link Address bar
Simulator Screenshot - iPhone 14 Pro - 2023-09-07 at 11 34 02 Screenshot 2023-09-07 at 11 31 38 AMScreenshot 2023-09-07 at 11 31 04 AM

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba force-pushed the js/6179-clean-copy branch 2 times, most recently from 1372ba1 to 49e8c22 Compare August 17, 2023 21:14
@cuba cuba force-pushed the js/6179-clean-copy branch 2 times, most recently from f15e638 to 974de60 Compare September 5, 2023 17:14
@cuba cuba changed the base branch from brave-core-1.54.x to development September 7, 2023 15:43
@cuba cuba force-pushed the js/6179-clean-copy branch 2 times, most recently from 2d07758 to f2e0c6b Compare September 7, 2023 16:58
@cuba cuba marked this pull request as ready for review September 7, 2023 17:35
@cuba cuba requested a review from a team as a code owner September 7, 2023 17:35
@cuba cuba force-pushed the js/6179-clean-copy branch 3 times, most recently from 6befdb5 to 1ec9df1 Compare September 7, 2023 17:44
iccub
iccub approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iccub iccub added this to the 1.58 milestone Sep 15, 2023
@iccub iccub merged commit 2c3b47c into development Sep 15, 2023
8 checks passed
@iccub iccub deleted the js/6179-clean-copy branch September 15, 2023 14:52
@iccub
Copy link
Contributor

iccub commented Sep 15, 2023

Remember to add a test plan for it later

arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@cuba
Fix brave/brave-ios#6179: Add clean copy feature (brave/brave-ios#7696)
e417faa
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.58
Development

Successfully merging this pull request may close these issues.

"Copy clean URL" feature
3 participants
@cuba @iccub @kylehickinson