Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uintN; 0 < N <=256, N%8 == 0 for typed data (uplift to 1.38.x) #12992

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Apr 12, 2022

Important for Dapp compatibility for loopring.io l2 activation

Uplift of #12958
Resolves brave/brave-browser#22070

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bbondy bbondy added this to the 1.38.x - Beta milestone Apr 12, 2022
@bbondy bbondy requested a review from a team April 12, 2022 18:34
@bbondy bbondy requested a review from a team as a code owner April 12, 2022 18:34
@bbondy bbondy self-assigned this Apr 12, 2022
@kjozwiak
Copy link
Member

Restarting Win due to build failing as per the following:

FAILED: obj/brave/browser/renderer_context_menu/renderer_context_menu/brave_spelling_options_submenu_observer.obj 
15:32:21  C:\ws\src\brave\buildtools\win\redirect-cc\bin\redirect-cc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe /c ../../brave/browser/renderer_context_menu/brave_spelling_options_submenu_observer.cc /Foobj/brave/browser/renderer_context_menu/renderer_context_menu/brave_spelling_options_submenu_observer.obj /nologo /showIncludes "-imsvc../../../../Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/ATLMFC/include" "-imsvc../../../../Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/include" "-imsvc../../../../Program Files (x86)/Windows Kits/NETFXSDK/4.8/include/um" "-imsvc../../../../Program Files (x86)/Windows Kits/10/include/10.0.19041.0/ucrt" "-imsvc../../../../Program Files (x86)/Windows Kits/10/include/10.0.19041.0/shared" "-imsvc../../../../Program Files (x86)/Windows Kits/10/include/10.0.19041.0/um" "-imsvc../../../../Program Files (x86)/Windows Kits/10/include/10.0.19041.0/winrt" "-imsvc../../../../Program Files (x86)/Windows Kits/10/include/10.0.19041.0/cppwinrt" "-DBRAVE_SERVICES_KEY=\"****\"" "-DUPDATER_DEV_ENDPOINT=\"[https://go-updater-dev.bravesoftware.com/extensions\](https://go-updater-dev.bravesoftware.com/extensions/)"" "-DUPDATER_PROD_ENDPOINT=\"[https://go-updater.brave.com/extensions\](https://go-updater.brave.com/extensions/)"" -DUSE_AURA=1 "-DCR_CLANG_REVISION=\"llvmorg-15-init-1995-g5bec1ea7-1\"" -D_HAS_NODISCARD -D_CRT_NONSTDC_NO_WARNINGS -D_WINSOCK_DEPRECATED_NO_WARNINGS -D_LIBCPP_ABI_UNSTABLE -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_NODISCARD -D_LIBCPP_NO_AUTO_LINK -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=NTDDI_WIN10_VB -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBP_EXTERN=extern -DENABLE_IPC_FUZZER -DUSE_EGL -DVK_USE_PLATFORM_WIN32_KHR -D_WTL_NO_AUTOMATIC_NAMESPACE -DTOOLKIT_VIEWS=1 -DSK_CODEC_DECODES_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED "-DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\"" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_GL -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_HAS_WUFFS_LIBRARY -DSK_VULKAN=1 -DSK_DAWN -DSK_SUPPORT_GPU=1 "-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DGR_GL_FUNCTION_TYPE=__stdcall -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../../brave/chromium_src -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/third_party/dawn/include -I../../third_party/dawn/include -I../../third_party/dawn/src/include -I../../third_party/libwebp/src -I../../third_party/libyuv/include -I../../third_party/jsoncpp/source/include -I../../third_party/vulkan-deps/vulkan-headers/src/include -I../../third_party/khronos -I../../gpu -I../../third_party/wtl/include -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/skia -I../../third_party/wuffs/src/release/c -I../../third_party/vulkan/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../.. -fno-delete-null-pointer-checks -fno-ident -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 /clang:-ffp-contract=off -fcomplete-member-pointers /Gy /FS /bigobj /utf-8 /Zc:twoPhase /Zc:sizedDealloc- /D__WRL_ENABLE_FUNCTION_STATICS__ -fmsc-version=1916 -m64 -msse3 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. -no-canonical-prefixes /W4 -Wimplicit-fallthrough -Wthread-safety -Wextra-semi /WX -Wno-missing-field-initializers -Wno-unused-parameter -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-nonportable-include-path -Wno-null-pointer-subtraction -Wenum-compare-conditional -Wno-psabi -Wno-ignored-pragma-optimize -Wmax-tokens -Wshadow /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /Z7 -gcodeview-ghash -Xclang -fuse-ctor-homing -ftrivial-auto-var-init=pattern /guard:cf /MT -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang raw-ptr-template-as-trivial-member -Xclang -plugin-arg-find-bad-constructs -Xclang use-classify-type -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -DPROTOBUF_ALLOW_DEPRECATED=1 /std:c++17 -Wno-trigraphs /Zc:alignedNew- /TP /GR- -I../../buildtools/third_party/libc++/trunk/include -Wno-deprecated-declarations /Fd"obj/brave/browser/renderer_context_menu/renderer_context_menu_cc.pdb"
15:32:21  In file included from ../../brave/browser/renderer_context_menu/brave_spelling_options_submenu_observer.cc:5:
15:32:21  In file included from ../..\brave/browser/renderer_context_menu/brave_spelling_options_submenu_observer.h:8:
15:32:21  In file included from ../..\chrome/browser/renderer_context_menu/spelling_options_submenu_observer.h:12:
15:32:21 
 ../..\chrome/browser/spellchecker/spellcheck_service.h(25,10): fatal error: 'components/spellcheck/common/spellcheck.mojom-forward.h' file not found

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #12958 (comment).

@kjozwiak kjozwiak merged commit 1e08afd into 1.38.x Apr 16, 2022
@kjozwiak kjozwiak deleted the typed-data-intN-1.38.x branch April 16, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants