Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support [u]intN; 0 < N <=256, N%8 == 0 for typed data #12958

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Apr 9, 2022

Resolves brave/brave-browser#22070

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to Loopring.io
  2. Do the l2 activation by sending in the needed eth
  3. Sign on the prompt
  4. Sign again with the typed data prompt
  5. It should succeed

@bbondy bbondy requested a review from darkdh April 9, 2022 17:55
@bbondy bbondy requested a review from a team as a code owner April 9, 2022 17:55
@bbondy bbondy self-assigned this Apr 9, 2022
@bbondy bbondy changed the title Support uintN; 0 < N <=256, N%8 == 0 for typed data Support [u]intN; 0 < N <=256, N%8 == 0 for typed data Apr 9, 2022
@bbondy bbondy added this to the 1.39.x - Nightly milestone Apr 11, 2022
@bbondy bbondy merged commit 09fcdeb into master Apr 12, 2022
@bbondy bbondy deleted the typed-data-intN branch April 12, 2022 16:37
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.39.57 Chromium: 101.0.4951.34 (Official Build) nightly (64-bit)
-- | --
Revision | 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS | Windows 11 Version 21H2 (Build 22000.613)

Verified the STR/Cases outlined via #12958 (comment) as per the following:

Example Example Example Example
1 2 3 4

Ensured that you can also Lock/Unlock without any issues:

Example Example
5 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loopring.io L2 activation fails for 2nd sign request (eth_signTypedData_v4)
3 participants