Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Shields down text (uplift to 1.38.x) #12991

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Update Shields down text (uplift to 1.38.x) #12991

merged 1 commit into from
Apr 13, 2022

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Apr 12, 2022 •
edited by kjozwiak
Loading

Uplift of #12959
Resolves brave/brave-browser#22189

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Tonev
Update Shields down text
1d0463c 
This commit updates the Brave Shields down text for consistency with other Brave Shields texts.
@nullhook nullhook added this to the 1.38.x - Beta milestone Apr 12, 2022
@nullhook nullhook requested a review from a team April 12, 2022 17:42
@nullhook nullhook removed this from the 1.38.x - Beta milestone Apr 12, 2022
@kjozwiak kjozwiak added this to the 1.38.x - Beta milestone Apr 13, 2022
@kjozwiak kjozwiak mentioned this pull request Apr 13, 2022
Closed
kjozwiak
kjozwiak approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#22189 (comment).

@kjozwiak kjozwiak merged commit 99c9959 into 1.38.x Apr 13, 2022
@kjozwiak kjozwiak deleted the shields-panel-privacy-text-1.38.x branch April 13, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@nullhook nullhook

Labels
None yet
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@nullhook @kjozwiak @Tonev