Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent pluralization and missing period at end of sentence, in Brave Shields Up/Down texts #22189

Closed
stephendonner opened this issue Apr 9, 2022 · 6 comments · Fixed by brave/brave-core#12959
Assignees
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

stephendonner commented Apr 9, 2022

Description

Inconsistent pluralization and missing period at end of sentence, in Brave Shields Up/Down texts

Steps to Reproduce

  1. install 1.39.22
  2. launch Brave
  3. load cnn.com
  4. click on the Shields icon in the URL bar
  5. compare text between Shields UP and DOWN states

Actual result:

Shields UP: Note: this may reduce Brave's privacy protections.
Shields DOWN: You are viewing this site without Brave's privacy protection

Shields UP Shields DOWN
Screen Shot 2022-04-08 at 7 57 16 PM Screen Shot 2022-04-08 at 7 57 21 PM

Expected result:

Shields DOWN text should probably read "You are viewing this site without Brave's privacy protections."

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.22 Chromium: 100.0.4896.60 (Official Build) nightly (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 12.4 (Build 21F5048e)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @nullhook @jenn-rhim @rmcfadden3 @rebron

@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. QA/Yes QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Apr 9, 2022
@stephendonner
Copy link
Author

Interested, @Tonev ?

@Tonev
Copy link
Contributor

Tonev commented Apr 10, 2022

Hey, @stephendonner!

brave/brave-core#12959

6c1uv2

@stephendonner
Copy link
Author

Verified PASSED using this issue's URL as a testcase, with build

Brave 1.39.45 Chromium: 100.0.4896.79 (Official Build) nightly (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed text changes; thanks @Tonev!

Shields UP Shields DOWN
Screen Shot 2022-04-11 at 3 39 14 PM Screen Shot 2022-04-11 at 3 39 20 PM

@kjozwiak
Copy link
Member

Removing QA Pass-macOS as this is going to be uplifted into 1.38.x via brave/brave-core#12991 so worth checking again just in case. However, we'll use #22189 (comment) as the verification needed to get the above uplifted.

@kjozwiak
Copy link
Member

Above will require 1.38.93 or higher for 1.38.x verification.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.38.93 Chromium: 100.0.4896.88 (Official Build) beta (x86_64)
Revision 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS macOS Version 12.4 (Build 21F5048e)

Confirmed text changes

Shields UP Shields DOWN
Screen Shot 2022-04-16 at 3 03 42 AM Screen Shot 2022-04-16 at 3 03 46 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants