-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPFS updater version to brave://ipfs page #12159
Conversation
A Storybook has been deployed to preview UI for the latest push |
39909aa
to
5e5556d
Compare
A Storybook has been deployed to preview UI for the latest push |
5e5556d
to
fdae792
Compare
A Storybook has been deployed to preview UI for the latest push |
#include "brave/components/ipfs/ipfs_service.h" | ||
#include "brave/components/ipfs/repo_stats.h" | ||
#include "brave/components/ipfs_ui/resources/grit/ipfs_generated_map.h" | ||
#include "chrome/browser/browser_process_impl.h" | ||
#include "components/component_updater/component_updater_service.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need a dependency added in browser/ui/BUILD.gn
for components/component_updater
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
A Storybook has been deployed to preview UI for the latest push |
* Add IPFS updater version to brave://ipfs page
Resolves brave/brave-browser#18493
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: