This repository has been archived by the owner on May 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 883
High Sierra #863
Open
jacobbednarz
wants to merge
32
commits into
master
Choose a base branch
from
high-sierra
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
High Sierra #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: Hiera Update for Puppet 4
Updates the suite to use the secure environment variables from the UI and ditch `--token` since we are using password auth.
0ea8dfb
to
30e2876
Compare
4 tasks
686a4e2
to
a34ff05
Compare
Addressing permission in https://travis-ci.org/boxen/our-boxen/builds/348769946#L162
f51d555
to
cdc083c
Compare
We shouldn't need to be bundling here as the gems should be stored in the repository cached already.
Updates Boxen to use a fork of the `librarian` gem since the regex matching for git environment variables was a bit too loose and overexposed GitHub credentials.
4ce0769
to
0f08582
Compare
0f08582
to
c8b6163
Compare
If for any reason Puppet is already on the PATH, get rid of it to stop it interferring with commands. Fixes the following error: ``` Error: Could not create resources for managing Puppet's files and directories in sections [:main, :agent, :ssl]: undefined method `exists?' for nil:NilClass Error: Could not prepare for execution: Could not create resources for managing Puppet's files and directories in sections [:main, :agent, :ssl]: undefined method `exists?' for nil:NilClass ```
During fresh VM runs, I was getting the following exceptions: ``` Warning: Facter: Error loading fact /opt/boxen/repo/.bundle/ruby/2.3.0/gems/facter-2.5.1/lib/facter/processor.rb: cannot load such file -- cfpropertylist Error: Could not run: cannot load such file -- cfpropertylist ``` To fix this, I'm explicitly adding it to the Gemfile.
a45cda1
to
53297f4
Compare
50eacab
to
604c811
Compare
604c811
to
59fda69
Compare
10bf2b9
to
c1f1911
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking branch to merge intermediate branches into whilst we get High Sierra support going.