Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preview-error): Display file icon based on extension for errors #1536

Merged
merged 2 commits into from
Oct 4, 2024
Merged

feat(preview-error): Display file icon based on extension for errors #1536

merged 2 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. feat(preview-error): Display file icon based on extension for errors 

    * Remove restriction such that preview will fetch the icon based on the extension from box-ui-elements when there is a preview error. Will rely on the logic there to return a default icon when one does not exist for the extension.

See: https://github.com/box/box-ui-elements/blob/1850977829e4888139462a6f65794b1cffc52a08/src/components/preview/previewIcons.ts#L183
    @patlm
    patlm committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6076e76 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into always-use-file-icon-for-errors

    @patlm
    patlm authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0d41ce8 View commit details
    Browse the repository at this point in the history