feat(preview-error): Display file icon based on extension for errors #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcbgaston
reviewed
Oct 3, 2024
| @@ -80,8 +80,7 @@ class PreviewErrorViewer extends BaseViewer { | |||
|
|
|||
| const { displayMessage, details, message } = error; | |||
| const { file } = this.options; | |||
| const { extension } = file || {}; | |||
| const iconExtension = extension === 'flv' || extension === 'tgz' || extension === 'zip' ? extension : undefined; | |||
| const { extension: iconExtension } = file || {}; | |||
There was a problem hiding this comment.
what happens if iconExtension is undefined?
There was a problem hiding this comment.
These scenarios will be handled by getIcon in box-ui-elements. In the case of undefined, it will return the same default item as it returned before when iconExtension was explicitly set to undefined.
jmcbgaston
reviewed
Oct 3, 2024
| @@ -55,7 +55,8 @@ describe('lib/viewers/error/PreviewErrorViewer', () => { | |||
| ['zip', 'zip'], | |||
| ['tgz', 'tgz'], | |||
| ['flv', 'flv'], | |||
| ['blah', undefined], | |||
| ['pdf', 'pdf'], | |||
| ['pptx', 'pptx'], | |||
There was a problem hiding this comment.
is it still possible for [blah, undefined] to happen?
There was a problem hiding this comment.
It will no longer be possible. If 'blah' is the extension, it will be passed into box-ui-elements getIcon function which in the case where it can not find it, it will return the default icon that was previous being used when iconExtension was passed in as undefined.
* Remove restriction such that preview will fetch the icon based on the extension from box-ui-elements when there is a preview error. Will rely on the logic there to return a default icon when one does not exist for the extension. See: https://github.com/box/box-ui-elements/blob/1850977829e4888139462a6f65794b1cffc52a08/src/components/preview/previewIcons.ts#L183
patlm
force-pushed
the
always-use-file-icon-for-errors
branch
from
4380397
to
6076e76
Compare
JChan106
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove restriction such that preview will fetch the icon based on the extension from box-ui-elements when there is a preview error. Will rely on the logic there to return a default icon when one does not exist for the extension.
See: https://github.com/box/box-ui-elements/blob/1850977829e4888139462a6f65794b1cffc52a08/src/components/preview/previewIcons.ts#L183
Screenshots
