Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Separately version third-party assets #15

Merged
merged 1 commit into from
Mar 24, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ node_modules
.DS_Store
npm-debug.log
reports
dist/dev
dist
src/i18n/json
jsconfig.json
4 changes: 3 additions & 1 deletion build/karma.conf.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
const webpackConfig = require('./webpack.karma.config');

const MODEL3D_STATIC_ASSETS_VERSION = '0.112.0';

const getTestFile = (src) => {
if (!src) {
return [
Expand Down Expand Up @@ -81,7 +83,7 @@ module.exports = (config) => config.set({
],

files: [
'src/third-party/model3d/three.min.js',
`src/third-party/model3d/${MODEL3D_STATIC_ASSETS_VERSION}/three.min.js`,
'node_modules/babel-polyfill/dist/polyfill.js',
'src/third-party/**/*.js'
].concat(getTestFile(config.src)),
Expand Down
13 changes: 9 additions & 4 deletions build/minify_pdfjs.sh
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
DOC_STATIC_ASSETS_VERSION=$(./build/current_version.sh)

# Minify using Google Closure Compiler, options:
# Output to ECMASCRIPT5 / ES5 (Box supports Chrome, IE11, Firefox, Safari, and newer versions of iOS, Android)
# Skip rewriting polyfills since pdf.js includes its own WeakMap polyfill
echo "-----------------------------------------------------------------------------------"
echo "Minifying pdf.js files with Google Closure... Warnings are okay!"
echo "-----------------------------------------------------------------------------------"
java -jar build/closure-compiler-v20161201.jar --rewrite_polyfills false --language_out ECMASCRIPT5 --js src/third-party/doc/pdf.js --js_output_file src/third-party/doc/pdf.min.js
java -jar build/closure-compiler-v20161201.jar --rewrite_polyfills false --language_out ECMASCRIPT5 --js src/third-party/doc/pdf.worker.js --js_output_file src/third-party/doc/pdf.worker.min.js
java -jar build/closure-compiler-v20161201.jar --rewrite_polyfills false --language_out ECMASCRIPT5 --js src/third-party/doc/pdf_viewer.js --js_output_file src/third-party/doc/pdf_viewer.min.js
java -jar build/closure-compiler-v20161201.jar --rewrite_polyfills false --language_out ECMASCRIPT5 --js src/third-party/doc/compatibility.js --js_output_file src/third-party/doc/compatibility.min.js
java -jar build/closure-compiler-v20161201.jar --rewrite_polyfills false --language_out ECMASCRIPT5 --js src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/pdf.js --js_output_file src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/pdf.min.js

java -jar build/closure-compiler-v20161201.jar --rewrite_polyfills false --language_out ECMASCRIPT5 --js src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/pdf.worker.js --js_output_file src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/pdf.worker.min.js

java -jar build/closure-compiler-v20161201.jar --rewrite_polyfills false --language_out ECMASCRIPT5 --js src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/pdf_viewer.js --js_output_file src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/pdf_viewer.min.js

java -jar build/closure-compiler-v20161201.jar --rewrite_polyfills false --language_out ECMASCRIPT5 --js src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/compatibility.js --js_output_file src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/compatibility.min.js
echo "-----------------------------------------------------------------------------------"
echo "Successfully updated and minified pdf.js files!"
echo "-----------------------------------------------------------------------------------"
14 changes: 8 additions & 6 deletions build/upgrade_pdfjs.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
DOC_STATIC_ASSETS_VERSION=$(./build/current_version.sh)

echo "-----------------------------------------------------------------------------------"
echo "Fetching latest pdf.js files from pdfjs-dist repo..."
echo "-----------------------------------------------------------------------------------"
Expand All @@ -8,15 +10,15 @@ echo "--------------------------------------------------------------------------
echo "Copying relevant files to Preview third-party dir..."
echo "Note that we are NOT copying compatibility.js - that needs to be manually updated"
echo "-----------------------------------------------------------------------------------"
cp pdfjs-dist/build/pdf.js src/third-party/doc/
cp pdfjs-dist/build/pdf.worker.js src/third-party/doc/
cp pdfjs-dist/web/pdf_viewer.js src/third-party/doc/
cp pdfjs-dist/web/pdf_viewer.css src/third-party/doc/
cp pdfjs-dist/cmaps/* src/third-party/doc/cmaps/
cp pdfjs-dist/build/pdf.js src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/
cp pdfjs-dist/build/pdf.worker.js src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/
cp pdfjs-dist/web/pdf_viewer.js src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/
cp pdfjs-dist/web/pdf_viewer.css src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/
cp pdfjs-dist/cmaps/* src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/cmaps/
rm -rf ./pdfjs-dist/

# Fix Chrome console warning issue by not testing for moz-chunked-arraybuffer support in Chrome
echo "-----------------------------------------------------------------------------------"
echo "Tweaking pdf.worker.js for Chrome..."
echo "-----------------------------------------------------------------------------------"
sed -e 's/function supportsMozChunkedClosure/!\(\/Chrome\/\.test\(navigator\.userAgent\)\) \&\& function supportsMozChunkedClosure/' -i '' src/third-party/doc/pdf.worker.js
sed -e 's/function supportsMozChunkedClosure/!\(\/Chrome\/\.test\(navigator\.userAgent\)\) \&\& function supportsMozChunkedClosure/' -i '' src/third-party/doc/$DOC_STATIC_ASSETS_VERSION/pdf.worker.js
2 changes: 1 addition & 1 deletion build/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const version = isRelease ? require('../package.json').version : 'dev';

const lib = path.resolve('src/lib');
const thirdParty = path.resolve('src/third-party');
const staticFolder = path.resolve('dist', version);
const staticFolder = path.resolve('dist');

const languages = isRelease ? [
'en-AU',
Expand Down
2 changes: 0 additions & 2 deletions dist/0.112.0/da-DK/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/da-DK/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/da-DK/preview.js

This file was deleted.

Binary file removed dist/0.112.0/da-DK/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/de-DE/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/de-DE/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/de-DE/preview.js

This file was deleted.

Binary file removed dist/0.112.0/de-DE/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/en-AU/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/en-AU/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/en-AU/preview.js

This file was deleted.

Binary file removed dist/0.112.0/en-AU/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/en-CA/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/en-CA/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/en-CA/preview.js

This file was deleted.

Binary file removed dist/0.112.0/en-CA/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/en-GB/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/en-GB/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/en-GB/preview.js

This file was deleted.

Binary file removed dist/0.112.0/en-GB/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/en-US/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/en-US/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/en-US/preview.js

This file was deleted.

Binary file removed dist/0.112.0/en-US/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/es-ES/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/es-ES/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/es-ES/preview.js

This file was deleted.

Binary file removed dist/0.112.0/es-ES/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/fi-FI/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/fi-FI/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/fi-FI/preview.js

This file was deleted.

Binary file removed dist/0.112.0/fi-FI/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/fr-CA/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/fr-CA/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/fr-CA/preview.js

This file was deleted.

Binary file removed dist/0.112.0/fr-CA/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/fr-FR/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/fr-FR/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/fr-FR/preview.js

This file was deleted.

Binary file removed dist/0.112.0/fr-FR/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/it-IT/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/it-IT/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/it-IT/preview.js

This file was deleted.

Binary file removed dist/0.112.0/it-IT/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/ja-JP/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/ja-JP/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/ja-JP/preview.js

This file was deleted.

Binary file removed dist/0.112.0/ja-JP/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/ko-KR/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/ko-KR/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/ko-KR/preview.js

This file was deleted.

Binary file removed dist/0.112.0/ko-KR/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/nb-NO/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/nb-NO/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/nb-NO/preview.js

This file was deleted.

Binary file removed dist/0.112.0/nb-NO/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/nl-NL/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/nl-NL/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/nl-NL/preview.js

This file was deleted.

Binary file removed dist/0.112.0/nl-NL/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/pl-PL/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/pl-PL/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/pl-PL/preview.js

This file was deleted.

Binary file removed dist/0.112.0/pl-PL/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/pt-BR/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/pt-BR/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/pt-BR/preview.js

This file was deleted.

Binary file removed dist/0.112.0/pt-BR/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/ru-RU/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/ru-RU/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/ru-RU/preview.js

This file was deleted.

Binary file removed dist/0.112.0/ru-RU/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/sv-SE/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/sv-SE/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/sv-SE/preview.js

This file was deleted.

Binary file removed dist/0.112.0/sv-SE/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/tr-TR/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/tr-TR/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/tr-TR/preview.js

This file was deleted.

Binary file removed dist/0.112.0/tr-TR/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/zh-CN/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/zh-CN/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/zh-CN/preview.js

This file was deleted.

Binary file removed dist/0.112.0/zh-CN/src/lib/loadingIcon.gif
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/0.112.0/zh-TW/csv.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/0.112.0/zh-TW/preview.css

This file was deleted.

2 changes: 0 additions & 2 deletions dist/0.112.0/zh-TW/preview.js

This file was deleted.

Binary file removed dist/0.112.0/zh-TW/src/lib/loadingIcon.gif
Binary file not shown.
Loading