Chore: Separately version third-party assets #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tonyjin
commented
Mar 24, 2017
tonyjin
commented
- Move third-party assets into folder alongside versioned preview assets
- Separately version third-party assets within the subfolders
- This makes it so we don't cache-bust the third-party assets every time we do a preview release
- When third-party assets need to be updated, the version under the subdirectory should be changed to the current version
- constants.js keeps a list of the version of static assets referenced by the various viewers
- Remove dist/0.112.0 from version control, decided to not have folder there anymore (takes up space, hard to version correctly alongside third-party assets)
- Move third-party assets into folder alongside versioned preview assets - Separately version third-party assets within the subfolders - This makes it so we don't cache-bust the third-party assets every time we do a preview release - When third-party assets need to be updated, the version under the subdirectory should be changed to the current version - constants.js keeps a list of the version of static assets referenced by the various viewers - Also remove dist/0.112.0 from version control - no need to have the folder there
priyajeet
approved these changes
Mar 24, 2017
This was referenced Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.