Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix CI #468

Merged
merged 8 commits into from
Jul 27, 2020
Merged

Attempt to fix CI #468

merged 8 commits into from
Jul 27, 2020

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Jul 12, 2020 •
edited
Loading

Related to #454.

@villfa villfa marked this pull request as ready for review July 12, 2020 22:28
@villfa
Copy link
Contributor Author

villfa commented Jul 12, 2020 •
edited
Loading

The make box command still fails but I don't know how to debug it.

[Edit] Nevermind, I figured out. I've used PhpStorm to inspect the content of the generated phar files.

@theofidry theofidry mentioned this pull request Jul 16, 2020
Merged
@villfa
Copy link
Contributor Author

villfa commented Jul 26, 2020

@theofidry the build is finally green! 🎉

@theofidry theofidry merged commit 21dac17 into box-project:master Jul 27, 2020
@theofidry
Copy link
Member

Thank you very much @villfa!

@villfa villfa deleted the fix-test branch July 28, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@villfa @theofidry