Configuration::runGitCommand() now respects base-path #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discordier
changed the title
|
Failing tests appear to be unrelated to my changes - I have no clue how to address them. |
|
Thanks, will try to check this weekend! |
|
Is there anything I can do to assist? |
theofidry
reviewed
Jul 16, 2020
| 'git-commit-short' => 'git_commit_short', | ||
| 'git-tag' => 'git_tag', | ||
| 'git-version' => 'git_version', | ||
| 'replacements' => ['rand' => $rand = random_int(0, getrandmax())], |
There was a problem hiding this comment.
we can skip the non-necessary values replacement, datetime & date-format
There was a problem hiding this comment.
Changed with 4aa9f90
|
Sorry I appear to have forgotten to submit the review... I'm away this week, once back I'll have a look at #468 and hopefully this PR will be green and ready to merge :) |
This resolves a problem when having the configuration file not within the repository itself (eg. in CI environments). Now the configuration is using the `base-path` for running all git commands.
|
Rebased master, hopefully CI is green now. 😨 |
|
It does :) Thanks very much @discordier |
|
Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a problem when having the configuration file not within the repository itself (eg. in CI environments).
Now the configuration is using the
base-pathfor running all git commands.Fixes #465