Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BoutDataset.to_restarts() method #117

Merged
merged 19 commits into from
Sep 9, 2020
Merged

Commits on Apr 20, 2020

  1. Configuration menu
    Copy the full SHA
    e2a547f View commit details
    Browse the repository at this point in the history
  2. Add variables argument to BoutDataset.to_restart()

    Allows selecting only the needed variables, reducing the size of the
    resulting restart files.
    johnomotani committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    ac7a430 View commit details
    Browse the repository at this point in the history
  3. Implement BoutDataset.to_restart() method

    Creates restart files from a certain time-slice of a Dataset.
    johnomotani committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    3b93596 View commit details
    Browse the repository at this point in the history
  4. Don't return Dataset from BoutDataset.to_restarts()

    It's unlikely that a user will want method chaining with an output
    method, and returning the Dataset means we get a lot of printed output
    if we just call 'ds.bout.to_restarts()'.
    johnomotani committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    9e5e684 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Configuration menu
    Copy the full SHA
    6244aa6 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    d479669 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c5ce503 View commit details
    Browse the repository at this point in the history
  3. Fix boundary padding when creating restart files

    - Set data_vars="minimal" in concat() when combining boundary_pad with
      ds - ensures that variables without an x- or y-dimension do not have a
      new dimension added.
    - Make boundary_pad a copy of the boundary cells, then we can set to NaN
      instead of using the strange expression with 'where()'.
    - Call .load() on both boundary_pad and ds before combining. Ensures
      that concat() with data_vars="minimal" does not fail because of
      different dask-states of the underlying data arrays.
    johnomotani committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    78a3cbb View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Configuration menu
    Copy the full SHA
    44c7ad1 View commit details
    Browse the repository at this point in the history
  2. Update minimum dask to minimum version supported by xarray-0.16.0

    xarray requires less-than-6-months old dask, so 0.16.0 requires
    dask-2.10.
    johnomotani committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    323f64f View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Configuration menu
    Copy the full SHA
    0687d96 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Configuration menu
    Copy the full SHA
    96fc201 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c200c7 View commit details
    Browse the repository at this point in the history
  3. Update default values in test Datasets

    Probably more 'correct' and needed to make to_restart() tests work.
    johnomotani committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    cd4053c View commit details
    Browse the repository at this point in the history
  4. Fix _check_new_nxpe() and _check_new_nype()

    Most of checks need to check numbers divisible by MXSUB or MYSUB, not
    NXPE or NYPE.
    johnomotani committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4afedc2 View commit details
    Browse the repository at this point in the history
  5. Do not check ixseps1, ixseps2 in _check_new_nxpe()

    BOUT++ does not require ixseps1 or ixseps2 to be on processor
    boundaries, so allow any splitting in x where nxpe divides nx-2*mxg
    johnomotani committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6855725 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Configuration menu
    Copy the full SHA
    a0f92ed View commit details
    Browse the repository at this point in the history
  2. Test to_restart() including guard cells

    This is the most common case, so better to test this. Also tests more of
    the code as some functions are only used when there are guard cells.
    Leaving out no-guard-cell case just to save time on the tests (it's not
    commonly used).
    johnomotani committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    5c5641a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    606bd65 View commit details
    Browse the repository at this point in the history