Implement BoutDataset.to_restarts() method #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnomotani
added
enhancement
|
Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-09 13:51:02 UTC |
Allows selecting only the needed variables, reducing the size of the resulting restart files.
johnomotani
force-pushed
the
create-restarts
branch
from
fa3870b
to
bcb0ce5
Compare
Creates restart files from a certain time-slice of a Dataset.
johnomotani
force-pushed
the
create-restarts
branch
from
bcb0ce5
to
3b93596
Compare
It's unlikely that a user will want method chaining with an output method, and returning the Dataset means we get a lot of printed output if we just call 'ds.bout.to_restarts()'.
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 77.64% 77.88% +0.24%
==========================================
Files 14 14
Lines 2035 2139 +104
Branches 452 480 +28
==========================================
+ Hits 1580 1666 +86
- Misses 299 304 +5
- Partials 156 169 +13
Continue to review full report at Codecov.
|
- Set data_vars="minimal" in concat() when combining boundary_pad with ds - ensures that variables without an x- or y-dimension do not have a new dimension added. - Make boundary_pad a copy of the boundary cells, then we can set to NaN instead of using the strange expression with 'where()'. - Call .load() on both boundary_pad and ds before combining. Ensures that concat() with data_vars="minimal" does not fail because of different dask-states of the underlying data arrays.
xarray requires less-than-6-months old dask, so 0.16.0 requires dask-2.10.
Probably more 'correct' and needed to make to_restart() tests work.
Most of checks need to check numbers divisible by MXSUB or MYSUB, not NXPE or NYPE.
BOUT++ does not require ixseps1 or ixseps2 to be on processor boundaries, so allow any splitting in x where nxpe divides nx-2*mxg
This is the most common case, so better to test this. Also tests more of the code as some functions are only used when there are guard cells. Leaving out no-guard-cell case just to save time on the tests (it's not commonly used).
johnomotani
force-pushed
the
create-restarts
branch
from
8e60cba
to
606bd65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows restart files to be created from a BoutDataset, for any time-index in the dataset and for any valid nxpe, nype.
Based on
parallel-interpolationin order to avoid merge conflicts (although the conflicts are trivial so I could rebase easily if that's useful), and because the motivation for adding this now is to be able to useinterpolate_parallel()to create a higher-resolution Dataset, and then create restart files from the interpolated data.Could do with adding a test for this, at least writing out the restart files and then reading them back in and checking the fields are as expected.