makefile: remove dependencies from build-variant task #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Sep 20, 2024
| @@ -857,7 +857,7 @@ cargo build \ | |||
| ] | |||
|
|
|||
| [tasks.build-variant] | |||
| dependencies = ["fetch", "build-sbkeys", "publish-setup", "validate-kits"] | |||
| dependencies = ["fetch-sdk", "build-sbkeys", "publish-setup", "validate-kits"] | |||
There was a problem hiding this comment.
build-variant can also trigger the equivalent of build-package tasks, and for those we do need to run fetch-sources (for first-party sources under sources/) and fetch-vendored (for packages that need bundled Go modules prepared).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Due to the changes in build requirements created by the switch to building from kits, only the sdk and the kits should now be required to build a botlerocket variant
Testing done:
Used resulting twoliter binary to build a bottlerocket variant from the bottlerocket repo.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.