Configurable cluster domain #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
reviewed
Jul 13, 2020
|
@etungsten was kind enough to verify the functionality on all of the Kubernetes variants. :) |
- Improve description in README.md - Move default setting to the correct location - Use url::Host::parse for the validation
|
@tjkirch Thanks for the review. I think I addressed all your concerns. Let me know if there's more I can do. |
tjkirch
approved these changes
Jul 14, 2020
|
I'm happy with the changes, and all my testing looks good. Let me know if you need anything else changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This change allows users to set the value for the kubelet's clusterDomain setting. By default the clusterDomain is set to
cluster.local, but users can set it to any valid domain. A description of the clusterDomain setting can be found here.We have multiple EKS clusters and each uses a different clusterDomain. We'd prefer not to have all our EKS clusters using
cluster.local.Testing done:
Tested using the aws-k8s-1.15 variant on our EKS clusters. If no value is set for
settings.kubernetes.cluster-domainin the user data, the kubelet will be configured to usecluster.localfor the clusterDomain. This is the current behaviour. By default this PR doesn't change the current behaviour. If there is a value forsettings.kubernetes.cluster-domain, the kubelet will be configure to use that value for the clusterDomain.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.