Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: canonicalize to EC2 machine architecture #932

Merged
merged 1 commit into from
May 22, 2020

Conversation

jahkeup
Copy link
Member

@jahkeup jahkeup commented May 21, 2020

Issue number:

n/a

Description of changes:

There are places in which architectures may/must be provided vary in which identifier should be provided, like aarch64 and arm64. The amiize.sh script would get very far before an error is raised about an incorrect choice on the part of the caller. Instead of waiting until the aws ec2 register-image call, the script will now bail on invalid architectures and also will canonicalize the given value from a supported set (eg: aarch64 -> arm64).

This handles callers providing a mix of identifiers and maps to the
correct EC2 identifier.

Signed-off-by: Jacob Vallejo <jakeev@amazon.com>

Testing done:

I ran ./amiize.sh with --arch aarch64 and had a successful image on the other side.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This handles callers providing a mix of identifiers and maps to the
correct EC2 identifier.

Signed-off-by: Jacob Vallejo <jakeev@amazon.com>
@jahkeup jahkeup requested review from tjkirch and bcressey May 21, 2020 21:16
@jahkeup jahkeup merged commit 13bef9e into bottlerocket-os:develop May 22, 2020
@jahkeup jahkeup deleted the arm-amiize-for-arm branch May 22, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants