Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default wave files #881

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Add default wave files #881

merged 1 commit into from
Apr 3, 2020

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented Mar 27, 2020

Issue number:
Related to #596

Description of changes:
Adds default wave files, an associated README.md and updates the README.md in updater/ to refer to these new files.

Testing done:
Rendered the READMEs.
Validated all TOML .

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@zmrow zmrow self-assigned this Mar 27, 2020
@zmrow zmrow requested review from sam-aws and bcressey March 27, 2020 22:18
sources/updater/waves/README.md Outdated Show resolved Hide resolved
sources/updater/README.md Outdated Show resolved Hide resolved
sources/updater/waves/README.md Outdated Show resolved Hide resolved
@zmrow
Copy link
Contributor Author

zmrow commented Mar 30, 2020

Fixes the typo @webern caught.

@tjkirch tjkirch self-requested a review March 30, 2020 20:38
sources/updater/README.md Outdated Show resolved Hide resolved
sources/updater/waves/accelerated-waves.toml Outdated Show resolved Hide resolved
sources/updater/waves/ohno.toml Outdated Show resolved Hide resolved
sources/updater/waves/accelerated-waves.toml Outdated Show resolved Hide resolved
sources/updater/waves/README.md Outdated Show resolved Hide resolved
sources/updater/waves/README.md Outdated Show resolved Hide resolved
sources/updater/waves/README.md Outdated Show resolved Hide resolved
@zmrow
Copy link
Contributor Author

zmrow commented Apr 2, 2020

After much discussion, we've decided to change the format of these files. Given the amount of discussion/confusion it made sense for us to make these files more user friendly and NOT to require any knowledge of the inner workings of manifest.json.

The new format will be as follows and additional documentation of the format is included in the README.md.

[[wave]]
start_after = '2 hours'
fleet_percentage = 1

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers, but some suggestions to smooth it out a little.

sources/updater/waves/README.md Outdated Show resolved Hide resolved
sources/updater/waves/README.md Outdated Show resolved Hide resolved
sources/updater/waves/accelerated-waves.toml Outdated Show resolved Hide resolved
sources/updater/waves/default-waves.toml Outdated Show resolved Hide resolved
sources/updater/waves/ohno.toml Show resolved Hide resolved
sources/updater/waves/default-waves.toml Show resolved Hide resolved
sources/updater/waves/README.md Outdated Show resolved Hide resolved
@zmrow
Copy link
Contributor Author

zmrow commented Apr 3, 2020

Updated to address @tjkirch 's comments

Copy link
Contributor

@sam-aws sam-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

@zmrow zmrow merged commit 616bf7a into bottlerocket-os:develop Apr 3, 2020
@zmrow zmrow deleted the wave-files branch April 3, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants