Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiclient: update to use new futures, hyper, and tokio #809

Merged
merged 4 commits into from
Mar 2, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Feb 28, 2020

hyperlocal hasn't been updated to use the new hyper, so we switch to
hyper-unix-connector, which is essentially the same thing.


Thanks for @iliana for helping me figure out the stream traits!

Testing done:

Ran the apiserver and this updated apiclient locally. Checked settings, PATCHed settings in a named transaction, committed them, saw updated settings.

@tjkirch tjkirch requested a review from iliana February 28, 2020 22:58
@tjkirch
Copy link
Contributor Author

tjkirch commented Feb 28, 2020

(Note that this should not be merged until I update the rest of our dependencies, or we have conflicts between multiple versions of the http crate. I made this a separate PR because it's a little more complex for a single-crate update.

iliana
iliana approved these changes Feb 28, 2020
hyperlocal hasn't been updated to use the new hyper, so we switch to
hyper-unix-connector, which is essentially the same thing.
@tjkirch
Copy link
Contributor Author

tjkirch commented Mar 2, 2020

Rebase on develop, to get #805 so dependencies of removed code don't come into play.

tjkirch and others added 3 commits March 2, 2020 10:03
This is a `cargo update`, followed by updating dependencies found through
`cargo outdated -w` and removing unused dependencies found by
`cargo +nightly udeps --workspace`.

The manual updates are:
* nix to 0.17; no important changes
* http to 0.2; no important changes
* reqwest to 0.10; we now use the 'blocking' module since we only use reqwest synchronously
* gptman to 0.6.1; no important changes
@tjkirch tjkirch merged commit de6539d into actix-update Mar 2, 2020
@tjkirch tjkirch deleted the apiclient-update branch March 2, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants