Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename target-base-url to targets-base-url #788

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Conversation

webern
Copy link
Contributor

@webern webern commented Feb 27, 2020

Issue number:

N/A

Description of changes:

For consistency, rename target-base-url to targets-base-url throughout. This will match the TUF spec and the urls that will end with /targets.

Testing done:

cargo make
cargo make unit-tests

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@iliana iliana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we are building a release to do upgrade testing, I am happy with the change and testing done so far.

@webern
Copy link
Contributor Author

webern commented Feb 27, 2020

Assuming we are building a release to do upgrade testing, I am happy with the change and testing done so far.

Yes, an upgrade and downgrade will be part of the 'uber' test that I'm working on for the release.

sources/updater/updog/src/main.rs Show resolved Hide resolved
@webern webern merged commit 3d15466 into develop Feb 27, 2020
@tjkirch tjkirch deleted the targets-base-url branch February 27, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants