-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license metadata to first-party code #746
Conversation
|
||
**Terms of contribution:** | ||
|
||
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular verbiage needs to be added to the pull request template in our other repos.
MIT License | ||
Copyright Amazon.com, Inc., its affiliates, or other contributors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm being precise, there should be a blank line between these two. Most likely any SPDX matching thing is still going to match it though.
packages/util-linux/util-linux.spec
Outdated
mkdir -p %{buildroot}%{_cross_licensedir}/$lib | ||
echo "$lib - %{url}" >> %{buildroot}%{_cross_licensedir}/$lib/attribution.txt | ||
mkdir -p %{buildroot}%{_cross_licensedir}/%{_cross_os}$lib | ||
echo "$lib - %{url}" >> %{buildroot}%{_cross_licensedir}/%{_cross_os}$lib/attribution.txt | ||
done | ||
echo "SPDX-License-Identifier: LGPL-2.1-or-later" | tee -a %{buildroot}%{_cross_licensedir}/lib{blkid,mount,smartcols}/attribution.txt >/dev/null | ||
echo "SPDX-License-Identifier: BSD-3-Clause" | tee -a %{buildroot}%{_cross_licensedir}/libuuid/attribution.txt | ||
echo "SPDX-License-Identifier: LGPL-2.1-or-later" | tee -a %{buildroot}%{_cross_licensedir}/%{_cross_os}lib{blkid,mount,smartcols}/attribution.txt >/dev/null | ||
echo "SPDX-License-Identifier: BSD-3-Clause" | tee -a %{buildroot}%{_cross_licensedir}/%{_cross_os}libuuid/attribution.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes, and others in this file, look unrelated.
On the other hand, they are related to license metadata at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This most recent push replaces the last commit with one that removes the %{_cross_os} prefix from all the directories in /usr/share/licenses. @tjkirch |
Issue number:
#469
Description of changes:
This adds the top-level license files for Bottlerocket, sets the relevant metadata in the right places, and cleans up a few copyright-related things.
Non-nit requests for changes will likely need to go through a lawyer, so be careful what you wish for. :)
We somehow lost our pull request template in the move from the old repo, so it seemed the old file path wasn't working. This one might. Hard to test without merging (I copied and pasted it into this PR description).
Testing done:
An image builds. /usr/share/licenses (after mounting) looks fine.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.