Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributions and license files for non-Rust upstream packages #671

Merged
merged 3 commits into from
Jan 24, 2020

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Jan 21, 2020

This adds attribution.txt and relevant license files to /usr/share/licenses for all remaining packages (other than workspaces).

libgcc and libstd-rust don't have copies of their licenses in /usr/share/licenses yet, as I'll want to plumb that through the SDK container.

If folks want me to squash the per-package attribution commits I will do so.

Testing done: Thar builds.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iliana iliana requested a review from bcressey January 21, 2020 00:23
@iliana iliana changed the title More licenses Add attributions and license files for non-Rust upstream packages Jan 21, 2020
@iliana iliana requested a review from tjkirch January 22, 2020 18:23
packages/ca-certificates/ca-certificates.spec Outdated Show resolved Hide resolved
packages/ca-certificates/ca-certificates.spec Show resolved Hide resolved
packages/util-linux/util-linux.spec Outdated Show resolved Hide resolved
packages/acpid/acpid.spec Outdated Show resolved Hide resolved
packages/host-ctr/host-ctr.spec Outdated Show resolved Hide resolved
echo "%{name} - %{url}" >> %{buildroot}%{_cross_attribution_file} \
echo "SPDX-License-Identifier: %{license}" >> %{buildroot}%{_cross_attribution_file}
%_cross_attribution_vendor_dir %{_licensedir}/%{name}/vendor
if [ 0%{?_cross_first_party} -eq 0 ]; then \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth this machinery to avoid writing a "pending" license into first-party attribution files? I think I'd rather consistently see a file and have it say "pending" than have it be inconsistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put in this machinery to avoid creating an attribution.txt for the workspaces SRPM, because where would you even put it? And at that point I realized the attribution is for third-party packages. A system-wide "Thar is available under LicenseRef-Pending" in the release package would be more appropriate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chatted and I'm going to figure out the first-party attribution strategy once we have a license to actually copy into places.

packages/util-linux/util-linux.spec Outdated Show resolved Hide resolved
macros/shared Show resolved Hide resolved
@iliana
Copy link
Contributor Author

iliana commented Jan 24, 2020

⬆️ rebase
⬇️ util-linux comment fix, libgcc + libstd-rust license files

@iliana iliana merged commit 4b09828 into develop Jan 24, 2020
@iliana iliana deleted the more-licenses branch January 28, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants