Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lingering containerd config issues #597

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Fix lingering containerd config issues #597

merged 2 commits into from
Dec 19, 2019

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Dec 18, 2019

commit b03bb3c3f4b5a48092efcfd3253587e38f5db10b
Author: Tom Kirchner <tjk@amazon.com>
Date:   Wed Dec 18 13:27:03 2019 -0800

    Disable CRI plugin in aws-dev image's containerd config
    
    We already removed all of the CRI config in the dev image, but forgot to
    disable the plugin.

commit b9f90233b14f0ec3f6b2c2f66bfbd4b36a2d4349
Author: Tom Kirchner <tjk@amazon.com>
Date:   Wed Dec 18 13:32:29 2019 -0800

    Remove /etc/containerd/config.toml from containerd tmpfiles config
    
    f9784cb20505 removed config.toml from factorydir but we didn't remove it from
    tmpfiles, which led to a "No such file" error at startup.

Testing done:

Made aws-k8s AMI, Kubernetes still connected and a pod worked, admin/sheltie worked. Made aws-dev AMI, admin/sheltie worked, ran a Docker container OK.

No longer see the above "No such file" error on startup.

f9784cb removed config.toml from factorydir but we didn't remove it from
tmpfiles, which led to a "No such file" error at startup.
We already removed all of the CRI config in the dev image, but forgot to
disable the plugin.
@tjkirch tjkirch merged commit ccb2181 into develop Dec 19, 2019
@tjkirch tjkirch deleted the containerd-config branch December 19, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants