Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTALL: Fix kube-proxy option formatting #584

Merged
merged 1 commit into from
Dec 10, 2019
Merged

INSTALL: Fix kube-proxy option formatting #584

merged 1 commit into from
Dec 10, 2019

Conversation

sam-aws
Copy link
Contributor

@sam-aws sam-aws commented Dec 10, 2019

Issue #, if available:
N/A

Description of changes:
kube-proxy doesn't seem to like the "--option value" format anymore,
but "--option=value" appears to work fine. Update the install section
about conntrack options to match.

Signed-off-by: Samuel Mendoza-Jonas samjonas@amazon.com

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tested by starting an instance with the following daemonset config:

     - command:
        - kube-proxy
        - --v=2
        - --config=/var/lib/kube-proxy-config/config
        - --conntrack-max-per-core=0
        - --conntrack-min=0

and making sure kube-proxy starts and the node reaches Ready state.

kube-proxy doesn't seem to like the "--option value" format anymore,
but "--option=value" appears to work fine. Update the install section
about conntrack options to match.

Signed-off-by: Samuel Mendoza-Jonas <samjonas@amazon.com>
@sam-aws sam-aws merged commit 821bfad into develop Dec 10, 2019
@sam-aws sam-aws deleted the kube-proxy branch December 10, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants