Add RELEASE.toml #556
Add RELEASE.toml #556
Conversation
|
Fixed my typos |
To clarify, my understanding is that this version is "when you build this what version should it think it is" and not "this is the latest version of Thar" which would only be asserted by a git tag. Is that right? |
There was a problem hiding this comment.
this version is "when you build this what version should it think it is" and not "this is the latest version of Thar" which would only be asserted by a git tag. Is that right?
If you're making a distinction between "latest released version" and "next released version", then I think it's right - this will be the version upon the next release. The release will build using this version, and then we'll update the version, so that we can do the following release whenever we need.
| @@ -0,0 +1,6 @@ | |||
| version: "0.2.0" | |||
There was a problem hiding this comment.
nit: I'd prefer a header here, maybe [os] or [main] or ...?
There was a problem hiding this comment.
Why a header? The naming is going to be a bikeshed, and it's easier to access the data without... no?
There was a problem hiding this comment.
It just feels weird to have no header.
That's why it's a nit 😸
RELEASE.toml
Outdated
| [[migrations]] | ||
| from: "0.1.6" | ||
| to: "0.2.0" | ||
| names: ["borkseed", "host-containers-version"] |
There was a problem hiding this comment.
These need to be of the form migrate_VERSION_NAME, eg. migrate_0.1_borkseed.
Once we fold the datastore version into the image version we can update the migration tools to recognise migrate_0.2.0_borkseed instead.
The purpose of this file is to provide a single point of truth for anything that needs to reference the current version of Thar. It also contains the list of migrations for each version update.
|
Added |
|
@bcressey How should we reconcile this with the version that lives in Perhaps these remain in conflict (with |
The purpose of this file is to provide a single point of truth for
anything that needs to reference the current version of Thar. It also
contains the list of migrations for each version update.
Issue #, if available:
#537
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.