build: Use buildkit v0.6.2 and pin docker/dockerfile version #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iliana destroyer of worlds <iweller@amazon.com>
tjkirch
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
LGTM assuming your instance still joins OK. I don't see anything scary in https://github.com/moby/buildkit/releases, except perhaps "use systemd resolver if enabled" in 0.6.0
|
It joins my cluster 🎉 |
bcressey
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
Starting today, we all started seeing a bizarre error across several environments while building the sdk package, during the
./configurescript for host-tar:It was theorized that updating buildkit might fix it and it fixed it.
It was also theorized that maybe
docker/dockerfilechanged in an incompatible way. This wasn't the case but it's a good idea to pin the version anyway.Testing: Built Thar, it joins my cluster.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.