Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluto: Single client: reqwest::Client declaration #419

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

etungsten
Copy link
Contributor

Issue #, if available: #389

Description of changes:
Removes redundant declarations of reqwest::Client and let each
get_x_setting function borrow a single instance of reqwest::Client.

Testing:
Launch Thar instance and verified that all settings were still being generated correctly:

kubelet-env:

bash-5.0# cat /etc/kubernetes/kubelet/env        
NODE_IP=192.168.33.239
NODE_LABELS=testLabel=foo,testLabel2=bar
NODE_TAINTS=dedicated=experimental:PreferNoSchedule,special=true:PreferNoSchedule
POD_INFRA_CONTAINER_IMAGE=602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/pause-amd64:3.1

MaxPods:

bash-5.0# cat /etc/kubernetes/kubelet/config     
...
MaxPods: 29

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@etungsten
Copy link
Contributor Author

etungsten commented Oct 16, 2019

Addresses @tjkirch 's comment.
Edit: Didn't actually add my changes. Added in the push below

Removes redundant declarations of reqwest::Client and let each
get_x_setting function borrow a single instance of reqwest::Client.
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

@etungsten etungsten merged commit 574462f into develop Oct 16, 2019
@etungsten etungsten deleted the pluto-redundant-clients branch October 16, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants