Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct documentation to state that NVIDIA container runtime is included, not CUDA toolkit #4169

Merged

Conversation

bryantbiggs
Copy link
Contributor

Issue number:

Closes #

Description of changes:

  • Correct documentation to state that NVIDIA container runtime is included, not the CUDA toolkit
    • The NVIDIA container runtime (usually installed/configured via the NVIDIA *container toolkit) is required on the host when wanting to utilize NVIDIA GPUs within your containers
    • The NVIDIA CUDA toolkit is a user space component for developing CUDA based applications - this not required on the host, nor should it be for containerized environments

XRef - awslabs/amazon-eks-ami#1924 (comment)

Testing done:
None

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@bryantbiggs bryantbiggs changed the title chore: Correct documentation to state that NVIDIA container runtime is included, not CUDA toolkit docs: Correct documentation to state that NVIDIA container runtime is included, not CUDA toolkit Aug 30, 2024
Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is indeed just the subset of drivers that the NVIDIA container runtime expects which are packaged on the host.

I'd also drop the "included in your orchestrated containers" bit, since it doesn't make sense now.

The previous documentation was essentially written from the container's perspective - "if you have a container that includes the CUDA toolkit, then the nvidia variants have all the libraries etc needed for your container to work."

QUICKSTART-ECS.md Outdated Show resolved Hide resolved
QUICKSTART-EKS.md Outdated Show resolved Hide resolved
bryantbiggs and others added 2 commits September 4, 2024 10:43
Co-authored-by: Ben Cressey <ben@cressey.org>
Co-authored-by: Ben Cressey <ben@cressey.org>
@bcressey bcressey merged commit 3ddbd44 into bottlerocket-os:develop Sep 25, 2024
@bryantbiggs bryantbiggs deleted the chore/cuda-doc-clarification branch September 25, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants