Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OpenApi spec link in readme #4062

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

mgsharm
Copy link
Contributor

@mgsharm mgsharm commented Jun 20, 2024

Issue number: N/A

Closes # N/A

Description of changes:

  • Fixes broken link for OpenApi spec in ReadMe.md

Testing done:

Open the hyperlink in ReadME and checked it worked and pointed to correct file.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@sumukhballal
Copy link
Contributor

There are a few links that are missing that could be part of this PR too. Like most of the packages/* links, most of which have moved. We'd probably want to add all of them into one documentation update PR, so its a bit easier on the reviewers and keeps our commit history a bit cleaner.

Examples:

https://github.com/bottlerocket-os/bottlerocket/blob/develop/packages/ecs-agent
...
https://github.com/bottlerocket-os/bottlerocket/blob/develop/sources/api/early-boot-config
...
etc

@mgsharm mgsharm closed this Jun 20, 2024
@mgsharm mgsharm reopened this Jun 20, 2024
@mgsharm
Copy link
Contributor Author

mgsharm commented Jun 24, 2024

Fixed more links that were broken.

Copy link
Contributor

@jmt-lab jmt-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumukhballal
Copy link
Contributor

Nice, thanks!

@mgsharm mgsharm merged commit a58dc41 into bottlerocket-os:develop Jun 24, 2024
@mgsharm mgsharm deleted the fix-openapi-spec-link branch June 24, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants