Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel-5.15: Default disable panic on hung task and lockups #3091

Merged
merged 1 commit into from
May 8, 2023

Conversation

foersleo
Copy link
Contributor

@foersleo foersleo commented May 8, 2023

Issue number: #3087

Description of changes:

Change the default for panic on hung tasks and lockups from default on to default off.
This is intended to be a discussion starter on if we want to change the default or not.

Setting panic as defaults for hung tasks and lockups is probably not the best
idea for the general case. In scenarios with remote storage we may see hangs
as interactions with that storage might be delayed due to network connectivity
issues. In such cases there is use cases that do not benefit from panic and reboot.

Disable the default for those panic options. This does not take away the option to
configure panic on hung tasks or lockups through either sysctl or kernel boot parameters.

As a bonus this aligns both kernels 5.10 and 5.15 on coherent settings for the panic choices.

Testing done:

Checked we are only changing the appropriate options:

config-aarch64-aws-dev-diff:      0 removed,   0 added,   4 changed
config-x86_64-aws-dev-diff:       0 removed,   0 added,   6 changed
==> configs_panic_disable/config-aarch64-aws-dev-diff <==
 BOOTPARAM_HUNG_TASK_PANIC y -> n
 BOOTPARAM_HUNG_TASK_PANIC_VALUE 1 -> 0
 BOOTPARAM_SOFTLOCKUP_PANIC y -> n
 BOOTPARAM_SOFTLOCKUP_PANIC_VALUE 1 -> 0

==> configs_panic_disable/config-x86_64-aws-dev-diff <==
 BOOTPARAM_HARDLOCKUP_PANIC y -> n
 BOOTPARAM_HARDLOCKUP_PANIC_VALUE 1 -> 0
 BOOTPARAM_HUNG_TASK_PANIC y -> n
 BOOTPARAM_HUNG_TASK_PANIC_VALUE 1 -> 0
 BOOTPARAM_SOFTLOCKUP_PANIC y -> n
 BOOTPARAM_SOFTLOCKUP_PANIC_VALUE 1 -> 0

No further testing done as these config options merely change the default value of a variable,
which may or may not be overridden at runtime or system boot through sysctl or kernel boot parameters.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Setting panic as defaults for hung tasks and lockups is probably not the
best idea for the general case. In scenarios with remote storage we may
see hangs as interactions with that storage might be delayed due to
network connectivity issues. In such cases there is use cases that do
not benefit from panic and reboot.

Disable the default for those panic options. This does not take away the
option to configure panic on hung tasks or lockups through either sysctl
or kernel boot parameters.

As a bonus this aligns both kernels 5.10 and 5.15 on coherent settings
for the panic choices.

Signed-off-by: Leonard Foerster <foersleo@amazon.com>
@foersleo foersleo requested a review from markusboehme May 8, 2023 15:59
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I like the consistency with 5.10.

@foersleo foersleo merged commit 68ae6c6 into bottlerocket-os:develop May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants