Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: added SSM and AMI validation targets #3043

Merged

Conversation

mjsterckx
Copy link
Contributor

Description of changes:

  • Added cargo make targets for the pubsys validate-ami and pubsys validate-ssm commands created in pubsys: added ami validation #3020 and pubsys: added SSM parameter validation #2969 respectively.
  • Added SSM output file arguments to the cargo make ssm and cargo make promote-ssm targets, so the SSM parameters will be written to a file in the same directory as amis.json, with the suffix ssm-params.json.

Testing done:

Ran cargo make, cargo make ami, cargo make ssm, cargo make promote-ssm followed by cargo make validate-ami:

+-----------+---------+-----------+---------+-------------+
| String    | correct | incorrect | missing | unreachable |
+-----------+---------+-----------+---------+-------------+
| us-west-2 | 1       | 0         | 0       | 0           |
+-----------+---------+-----------+---------+-------------+

and cargo make validate-ssm:

+-----------+---------+-----------+---------+------------+-------------+
| String    | correct | incorrect | missing | unexpected | unreachable |
+-----------+---------+-----------+---------+------------+-------------+
| us-west-2 | 4       | 0         | 0       | 0          | 0           |
+-----------+---------+-----------+---------+------------+-------------+

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Makefile.toml Outdated
@@ -106,6 +106,10 @@ DOCKER_BUILDKIT = "1"
# write AMI information to specifically named files.
AMI_DATA_FILE_SUFFIX = "amis.json"

# This is the filename suffix for operations that write out SSM parameter information
# to file. It can be overridden with -e.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Extra space between file. It

Makefile.toml Show resolved Hide resolved
Makefile.toml Show resolved Hide resolved
@mjsterckx mjsterckx merged commit 90778c0 into bottlerocket-os:develop Apr 25, 2023
@mjsterckx mjsterckx deleted the makefile-validate-commands branch April 25, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants