-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
models, pluto: generate 'provider-id' for aws-k8s variants #3026
models, pluto: generate 'provider-id' for aws-k8s variants #3026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if testing checks out.
4902a7f
to
29d8840
Compare
Push adds missing docstrings to new helper functions. |
Refactored out 'fetch_identity_document' from 'fetch_region' so it can used in 'fetch_zone' as well.
Adds a 'provider-id' subcommand to generate the appropriate provider ID for the node.
This migrates the new 'setting-generator' for 'provider-id' in aws-k8s variants.
29d8840
to
3fe1328
Compare
Push above rebases onto develop to get changelog updates. |
Push above adds a new commit for updating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's another push to be made, could update the date in the change log to 04-17
39aef16
to
5ee19f3
Compare
Push above adjusts the date in the changelog for 1.13.3 |
Issue number:
#3013
Description of changes:
Testing done:
Launched 10 aws-k8s-1.26 x86 nodes into subnet with hostname type set to "resource name"
All nodes became ready and none of them have taints:
After terminating 5 instances, and the nodes automatically gets de-registered.
Tested on aws-k8s-1.25 and saw the same results.
Tested on aws-k8s-1.24 and saw the same results.
Tested on aws-k8s-1.23 and saw the same results.
Tested on aws-k8s-1.22 and saw the same results.
Migration testing:
Launched 1.13.2 aws-k8s-1.26 x86 nodes and upgraded the host to image that includes these changes:
The host boots into 1.14.0 just fine, checked datastore and found the new
setting-generator
metadata forsettings.kubernetes.provider-id
:Checked the node, and noticed that the node now has a provider ID:
Then I rolled the host back to 1.13.2 and rebooted:
The host comes back fine and boots into 1.13.2, and the metadata
setting-generator
forprovider-id
is no longer there as expected:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.