[1.13.x] Cherry pick "systemd fixes for udevd skipping events" #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local filesystem is expected to be ready before local-fs.target is reached. Signed-off-by: Ben Cressey <bcressey@amazon.com> We don't need to wait for the 'repart' units since this cause boot to hang until the repart units timeout on waiting for a potentiaily non-existent data partition. 'systemd-repart' and 'systemd-makefs' both lock on the block device before operating on it, so repart is guaranteed to finish before makefs can create the filesystem. Co-authored-by: Erikson Tung <etung@amazon.com>
We explicitly stop and mask any repart-data service that has a start job waiting on a non-existent data partition after 'makefs' finishes successfully. This prevents awkward start job timeout messages from being printed to the console.
Backports the following, with some minor edits: * systemd/systemd@2d40f02 * systemd/systemd#22717 * systemd/systemd@400e3d2 * systemd/systemd@4f294ff * systemd/systemd@c02fb80 This fixes an issue with kernel uevents getting skipped by udev when the data partition block device is locked by 'systemd-makefs' or 'systemd-repart'.
yeazelm
approved these changes
Apr 11, 2023
stmcginnis
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Cherry-pick commits from #2999
Testing done:
See testing description in #2999
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.