Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building docs: fix positional fetch-license argument #2457

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Sep 26, 2022

Description of changes:

When going through the BUILDING.md docs and attempting to run the fetch-license target, the positonal arg is out of order, causing fetch license task to be skipped:

❯ cargo make fetch-licenses -e BUILDSYS_UPSTREAM_LICENSE_FETCH="true"
[cargo-make] INFO - cargo make 0.35.16
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: fetch-licenses
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: setup
[cargo-make] INFO - Running Task: setup-build
[cargo-make] INFO - Running Task: fetch-sdk
[cargo-make] INFO - Running Task: fetch-toolchain
[cargo-make] INFO - Running Task: fetch-sources
[cargo-make] INFO - Running Task: fetch-vendored
[cargo-make] INFO - Running Task: fetch-licenses
Skipping fetching licenses
[cargo-make] INFO - Build Done in 3.88 seconds.

Here it is working as intended with the right ordering:

❯ cargo make -e BUILDSYS_UPSTREAM_LICENSE_FETCH="true" fetch-licenses
[cargo-make] INFO - cargo make 0.35.16
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: fetch-licenses
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: setup
[cargo-make] INFO - Running Task: setup-build
[cargo-make] INFO - Running Task: fetch-sdk
[cargo-make] INFO - Running Task: fetch-toolchain
[cargo-make] INFO - Running Task: fetch-sources
[cargo-make] INFO - Running Task: fetch-vendored
[cargo-make] INFO - Running Task: fetch-licenses
Skipping copying file from /home/fedora/workspace/bottlerocket-os/bottlerocket/Licenses.toml
[cargo-make] INFO - Build Done in 4.14 seconds.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Signed-off-by: John McBride <jpmmcb@amazon.com>
@jpmcb jpmcb merged commit 3165f0a into bottlerocket-os:develop Sep 26, 2022
@jpmcb jpmcb deleted the fetch-licenses-doc branch September 26, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants