Updog: use compile time specific json payloads in unit tests #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmcb
force-pushed
the
updog-aarch-unit-tests
branch
from
b03aac3
to
f6a3c23
Compare
Modifies the updog unit tests to use architecture specific json stub files when those tests make assertions based on the host architecture. This patch fixes unit tests not working on aarch machines due to hard coded "x86_64" string literals. Signed-off-by: John McBride <jpmmcb@amazon.com>
jpmcb
force-pushed
the
updog-aarch-unit-tests
branch
from
f6a3c23
to
92bfbb3
Compare
|
Force pushed to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2366
Description of changes:
Adds a few files for
aarch64based machines and modifies the names of previous files to be have the new naming convention.Testing done:
Now able to fully run
cargo make unit-testswith no errorsTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.