docs: Update note about presence of boot settings to k8s-1.23 and beyond #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foersleo
approved these changes
Aug 18, 2022
etungsten
suggested changes
Aug 18, 2022
The settings model includes the boot settings on all bare metal variants and all k8s-1.23 variants. Future variants will pick up the setting as well. Signed-off-by: Markus Boehme <markubo@amazon.com>
markusboehme
force-pushed
the
docs/variants-with-boot-settings
branch
from
e94034a
to
bbf100d
Compare
|
Force push adopts Erikson's suggested wording. |
etungsten
approved these changes
Aug 19, 2022
mchaker
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: n/a
Description of changes:
Update the readme to add a note about the presence of boot settings. The settings model includes the boot settings on all k8s-1.23 variants now. Of the non-devel variants, metal-k8s-1.22 was first and deserves a special mention.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.