fix clippy warnings for tools and run lints for pull requests #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
changed the title
|
Let me run |
etungsten
approved these changes
Aug 12, 2022
Comment on lines
+374
to
+376
| # For rust first-party source code | ||
| if ! cargo clippy \ | ||
| --manifest-path ${BUILDSYS_TOOLS_DIR}/Cargo.toml \ |
There was a problem hiding this comment.
I guess the comment isn't exactly accurate yet. Are we planning to do this to first-party code in /sources as a follow up?
There was a problem hiding this comment.
Yes, I'd like first-party code to be covered as well, but it's more than I had the time to tackle today. I was working on an unrelated update to buildsys and got annoyed by the existing clippy warnings. 😀
Signed-off-by: Ben Cressey <bcressey@amazon.com>
bcressey
force-pushed
the
clippy-for-tools
branch
from
68f9642
to
7d3531c
Compare
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
bcressey
force-pushed
the
clippy-for-tools
branch
from
7d3531c
to
a2cf343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1776 (partial fix)
Description of changes:
Fix or silence all clippy warnings for
tools, and add a step to the pull request workflow so they stay fixed.Testing done:
Verified that builds completed via
buildsys.Ran the following
pubsysrelated tasks:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.