Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: README Markdown linting #2283

Merged

Conversation

mchaker
Copy link
Contributor

@mchaker mchaker commented Jul 16, 2022

Issue number:

#2282

Description of changes:

Standardize list item characters to * and add newlines
between paragraphs. Automatic linting from within VS Code.

Testing done:

eyeballs only 👀

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Standardize list item characters to `*` and add newlines
between paragraphs. Automatic linting from within VS Code.
@mchaker mchaker added the type/documentation Documentation update/creation label Jul 16, 2022
@mchaker mchaker requested a review from stockholmux July 16, 2022 10:05
Copy link
Member

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It might be worth iterating through some of the other README's that aren't auto-generated as well. (see sources/api and sources/updater)

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be good if we decide to enable some sort of markdown lint checking.

@mchaker
Copy link
Contributor Author

mchaker commented Jul 19, 2022

I did some digging and the linter is markdownlint, using Microsoft Docs Authoring Pack rules in VScode.

Adding the rules to a pipeline/github action should be possible.

@mchaker
Copy link
Contributor Author

mchaker commented Jul 19, 2022

I found what I think are the rules used by the Microsoft Docs Authoring Pack VScode extension (applied via markdownlint): https://github.com/microsoft/vscode-docs-authoring/tree/main/packages/docs-linting/markdownlint-custom-rules

@mchaker mchaker merged commit 4305c38 into bottlerocket-os:develop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation Documentation update/creation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants