adjust permissions for /boot and System.map #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.map is available in the kernel development tree on running systems, and in the downloadable kmod kit. The /boot filesystem is more space-constrained and we don't need an extra copy there. Signed-off-by: Ben Cressey <bcressey@amazon.com>
This is good practice although the security benefit is limited, since unprivileged containers would need a volume mount to access the file, and could be running as root. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Restrict these files to align with standard practice, even though all the contents are publicly available through the "boot" images in the updates repository. Signed-off-by: Ben Cressey <bcressey@amazon.com>
arnaldo2792
approved these changes
Jun 19, 2022
foersleo
approved these changes
Jun 20, 2022
markusboehme
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
System.maplikely isn't used by anything on modern systems, and the copy in/bootis even less likely to be used since for most of Bottlerocket's history (until 9e4c2cc) we didn't even mount that filesystem. Since/bootis space-constrained, especially on aarch64, we should just get rid of it.Make
/bootand the remaining copy ofSystem.mapreadable only by UID 0, per convention.Testing done:
Confirmed the new permissions on a running system.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.