Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: migrations for new admin and control versions #2191

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

rpkelly
Copy link
Contributor

@rpkelly rpkelly commented Jun 8, 2022

Description of changes:

  • admin-container: 0.8.0 → 0.9.0
  • control-container 0.6.0 → 0.6.1

Testing done:
aws-k8s-1.21 (x86_64) upgrade/downgrade

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Member

@gthao313 gthao313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -4,7 +4,7 @@ superpowered = true

[metadata.settings.host-containers.admin.source]
setting-generator = "schnauzer settings.host-containers.admin.source"
template = "{{ ecr-prefix settings.aws.region }}/bottlerocket-admin:v0.8.0"
template = "{{ ecr-prefix settings.aws.region }}/bottlerocket-admin:v0.9.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd prefer splitting the commit into two, one to move these defaults to the new host containers, and the other to add the migrations

@rpkelly rpkelly merged commit 9cb9498 into bottlerocket-os:develop Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants