Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-vm-tools: add recommended device filters #1603

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

etungsten
Copy link
Contributor

Issue number:
Fixes #1568

Description of changes:

Author: Erikson Tung <etung@amazon.com>
Date:   Thu Jun 3 16:12:42 2021 -0700

    open-vm-tools: add recommended device filters

    Adds the recommended device filters to VMTools config to prevent
    interference from CNI network/device interfaces.

    The list of filters is taken directly from cloud-provider-vsphere.

Testing done:
Built OVA, launched 3 VMs using said OVA and all of them came up fine. Ran pods fine. The vmtool version shows up in the vcenter UI.

vmtools running fine on the hosts

bash-5.0# systemctl status vmtoolsd
● vmtoolsd.service - VMware Tools service
     Loaded: loaded (/x86_64-bottlerocket-linux-gnu/sys-root/usr/lib/systemd/system/vmtoolsd.service; enabled; vendor preset: enabled)
     Active: active (running) since Fri 2021-06-04 00:16:10 UTC; 1min 17s ago
       Docs: https://github.com/vmware/open-vm-tools
   Main PID: 2797 (vmtoolsd)
      Tasks: 3 (limit: 9525)
     Memory: 3.2M
     CGroup: /system.slice/vmtoolsd.service
             └─2797 /usr/bin/vmtoolsd

Jun 04 00:16:10 198.19.8.9 systemd[1]: Started VMware Tools service.

bash-5.0# cat /etc/vmware-tools/tools.conf
[powerops]
poweron-script=/usr/bin/true
poweroff-script=/usr/bin/true
resume-script=/usr/bin/true
suspend-script=/usr/bin/true

[guestinfo]
primary-nics=eth0
exclude-nics=antrea-*,cali*,ovs-system,br*,flannel*,veth*,docker*,virbr*,vxlan_sys_*,genev_sys_*,gre_sys_*,stt_sys_*,????????-??????

Lemme know if there's anything else I should test.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Adds the recommended device filters to VMTools config to prevent
interference from CNI network/device interfaces.

The list of filters is taken directly from cloud-provider-vsphere.
@etungsten etungsten requested review from bcressey and zmrow June 4, 2021 00:19
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚴

Copy link
Member

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ????????-?????? really a valid nic value?

@etungsten
Copy link
Contributor Author

Is ????????-?????? really a valid nic value?

According to https://github.com/kubernetes/cloud-provider-vsphere/blob/master/docs/book/known_issues.md#vmtools-nicedevice-filtering it is valid:

Some filters, such as ????????-??????, aren't so straight-forward as that filter identifies Antrea devices which get created per POD.

@etungsten etungsten merged commit 674e22b into bottlerocket-os:develop Jun 7, 2021
@etungsten etungsten deleted the vmtools-device-filter branch June 7, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add recommended device filters to vmtoolsd configuration
5 participants