Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imdsclient: return options for all IMDS fetch functions #1598

Merged
merged 1 commit into from
May 26, 2021

Commits on May 26, 2021

  1. imdsclient: return options for all IMDS fetch functions

    This commit changes the return type for the IMDS fetch functions to
    options returning None when a 404 is encountered. This makes it easier
    for the caller to decide what to do when a 404 occurs and is closer to
    the behavior before imdsclient was written.
    
    `fetch_identity_document` and its associated `IdentityDocument` struct
    were removed in favor of separate `fetch_region` and
    `fetch_instance_type` functions. Instance-type is now fetched via IMDS
    meta-data as opposed to the identity document. We are returning to the
    original behavior as it is possible that the identity document can be
    absent in certain situations.
    
    Changes were also made to shibaken, pluto, and early-boot-config to
    accommodate the options detailed above.
    jpculp committed May 26, 2021
    Configuration menu
    Copy the full SHA
    fde8f46 View commit details
    Browse the repository at this point in the history