metricdog and updog: remove reqwest proxy workaround #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a workaround for HTTPS_PROXY values that have no protocol. The workaround is no longer needed because reqwest now does what we want.
We had a workaround for HTTPS_PROXY values that have no protocol. The workaround is no longer needed because reqwest now does what we want.
etungsten
approved these changes
May 24, 2021
jpculp
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #1332
Description of changes:
Before reqwest 11.1 we needed to check HTTPS_PROXY and, if it had no protocol, prepend the default (
http://). After 11.1 this behavior is provided by reqwest.Testing done:
I ran a tinyproxy server and gave Bottlerocket this in its userdata:
I ran Bottlerocket and observed that
updog check-updateandmetricdogwere functioning properly and I could see their traffic going through the tinyproxy server.Prior to seanmonstar/reqwest#1178, this would not have worked because reqwest did not default to
http://in the absence of a protocol.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.