release: remove timeout overrides for systemd units #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The key metric here is elapsed time from when reboot is initiated until systemd finishes shutting down everything and triggers the actual reboot. |
zmrow
approved these changes
Apr 13, 2021
How can we best gather that? |
The best way is by watching the console when the system is shutting down. |
arnaldo2792
force-pushed
the
remove-timeouts
branch
from
db76613
to
2f8d409
Compare
|
bcressey
approved these changes
Apr 14, 2021
This commit removes the `DefaultTimeoutStartSec` configuration, since services like kubernetes require more than 10 seconds to start in the vmware variant.
arnaldo2792
force-pushed
the
remove-timeouts
branch
from
2f8d409
to
63042d5
Compare
arnaldo2792
changed the title
|
bcressey
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1450
Description of changes:
This commit removes the
DefaultTimeoutStartSecconfiguration, since services like kubernetes require more than 10 seconds to start in the vmware variant.Only the
DefaultTimeoutStopSecis overwritten since kubernetes pods take longer to stop when using the default value (1min 30s), as shown in the logs:Testing done:
In k8s 1.19, ecs and dev aarch64:
systemctl statusto check that no units were failingTimeoutStopSecandTimeoutStartSecwithsystemctl show:DefaultTimeoutStartUSec=1min 30s # Was 10s DefaultTimeoutStopUSec=10scurl http://localhostfrom within the containerk8s 1.19
First boot:
Reboot:
ECS
First boot:
Reboot:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.