kubelet: make cluster-dns-ip optional #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gthao313
added
area/kubernetes
|
Nits on commit message:
|
zmrow
reviewed
Apr 13, 2021
There was a problem hiding this comment.
I'm happy once @bcressey 's suggestions re: the commit message are addressed. :)
Were you able to confirm that instances' config was correct with and without the setting? Could you add that to the testing section in the description?
gthao313
changed the title
Outside of EKS, we cannot compute a value for this, and there's not a reasonable default. We also need to account for it being optional for kubelet in standalone mode.
bcressey
approved these changes
Apr 14, 2021
gthao313
removed
area/kubernetes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1453
Description of changes:
Outside of EKS, we cannot compute a value for this, and there's not a reasonable default. We also need to account for it being optional for kubelet in standalone mode.
Testing done:
Since Those changes in different version kube-config are an identical change, and it works the same way in all versions, so we just need build aws-k8s-1.19-x86_64 and aws-k8s-1.19-aarch64 images to do test.
With
cluster-dns-ipdatabottlerocket-aws-k8s-1.19-x86_64-v1.0.8-b20d9ca6bottlerocket-aws-k8s-1.19-aarch64-v1.0.8-b20d9ca6Launching instances to validate if
clusterDNSworks as expectation.Without
cluster-dns-ipdata (removecluster-dns-ipvalue in50-aws-k8s.toml)bottlerocket-aws-k8s-1.19-x86_64-v1.0.8-ad8c4812-dirtybottlerocket-aws-k8s-1.19-aarch64-v1.0.8-ad8c4812-dirtyLaunching instances to validate if
clusterDNSis not inkubelet-config.(no
clusterDNSvalue there)Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.