Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: add script runner bash to link-variant #1323

Merged
merged 1 commit into from
Feb 16, 2021
Merged

makefile: add script runner bash to link-variant #1323

merged 1 commit into from
Feb 16, 2021

Conversation

webern
Copy link
Contributor

@webern webern commented Feb 16, 2021

Issue number:

N/A

Description of changes:

Without this change, builds were failing on some systems.

Testing done:

Add script runner=bash to the Makefile.toml for the link-variant target.
I haven't tested it, but @sanu11 reported that this fixed a build issue.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Without this change, builds were failing on some systems.
Copy link
Contributor

@sanu11 sanu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo make worked on ubuntu with this change, earlier it was failing.

@webern webern merged commit bc7a54a into bottlerocket-os:develop Feb 16, 2021
@webern webern deleted the makefile branch February 16, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants